Hi @aammd ,
Best post on the forum so far! Thanks very much for sharing your thoughts on the review process. Much appreciated!
Re 1. I don’t have a better solution than linking directly to line numbers or line ranges. It is a bit tedious, but it’s hard to comment otherwise unless you revisit specific commits, which takes up more effort than doing this.
Identical comments are probably a good thing, since that way we do know that it’s not just one reviewer’s personal coding preferences. But we have discussed what @noamross has written about asking reviewers to work on separate aspects. It still requires some testing though since I don’t think that is the right solution.
Re: 4, I wonder then if it would be worth taking a different approach. For larger issues regarding a package, write those in the onboarding comments. When you have specific fixes, post those in the package issues and just link to those in the review. So that way, individual fixes or changes can be discussed and closed separately. Perhaps a series of checkboxes in the main review would help keep track (we can try and automate some of this).